Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch event so listeners would see changed file #5446

Closed
wants to merge 1 commit into from

Conversation

yurynix
Copy link

@yurynix yurynix commented Feb 24, 2020

Closes #5420

In a similar way it's done at:
https://github.com/puppeteer/puppeteer/blob/master/lib/JSHandle.js#L305

We should notify listeners the input is changed.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yurynix
Copy link
Author

yurynix commented Feb 24, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gziolo
Copy link
Contributor

gziolo commented Feb 25, 2020

Just noting that there is a similar patch approved: #5389. I hope it's merged and a new version published to npm sooner than later. At the moment, it prevents upgrade to the latest version for projects that have media upload in their specs.

@mathiasbynens
Copy link
Member

Thanks! Closing in favor of #5389, which was merged.

@yurynix yurynix deleted the fix-upload branch March 26, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1.0 and 2.1.1 uploadFile failing
4 participants