Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use expect within Promises (#5466) #5473

Merged
merged 2 commits into from May 26, 2020
Merged

Don't use expect within Promises (#5466) #5473

merged 2 commits into from May 26, 2020

Commits on May 25, 2020

  1. Don't use expect within Promises (puppeteer#5466) 

    If a call to expect fails within a Promise it will not
be resolved, and causing the test to crash.

The patch aligns the code similar to what is used by all
the other tests.
    @whimboo
    whimboo committed May 25, 2020
    Configuration menu
    Copy the full SHA
    6e2d000 View commit details
    Browse the repository at this point in the history

  2. Update protocol definition.

    @whimboo
    whimboo committed May 25, 2020
    Configuration menu
    Copy the full SHA
    e0857d7 View commit details
    Browse the repository at this point in the history