Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 3.5 #5556

Merged
merged 1 commit into from Mar 31, 2020
Merged

Upgrade to TypeScript 3.5 #5556

merged 1 commit into from Mar 31, 2020

Commits on Mar 31, 2020

  1. chore: Upgrade to TypeScript 3.5

    TS 3.5 got much stricter on writing changes to objects with varied types
    [1] so we have to do a bit of typecasting work to convince TS about the
    types of keys and values that we are setting.
    
    Longer term we should think about a better data structure that avoids us
    having to jump through some hoops but for now I think this is a
    reasonable step to get us onto 3.5.
    
    Same story regarding bindings on `window`, the easiest fix is to cast
    window to any for the code that adds to it. I'm sure we can come up with
    a more type-safe way of doing this in the future.
    
    [1]: https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#fixes-to-unsound-writes-to-indexed-access-types
    jackfranklin committed Mar 31, 2020
    Copy the full SHA
    4b22524 View commit details
    Browse the repository at this point in the history