Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade TypeScript to 3.6 #5559

Merged
merged 1 commit into from Mar 31, 2020
Merged

Commits on Mar 31, 2020

  1. chore: Upgrade TypeScript to 3.6

    Continues the work to get up to TS 3.8 (latest release at time of
    writing).
    
    This version of TS introduced built in definitions for web workers that
    include an `interface Worker` so TS gets confused when it sees us
    reference a `Worker`. I have renamed the imports to `PuppeteerWorker` as
    I couldn't figure out a way to tell TS to not load in the worker types;
    longer term we might consider renaming `Worker` to `PuppeteerWorker` (or
    an alternative) but that would be a breaking change that we don't need
    right now.
    
    The other fix is similar; TypeScript doesn't differentiate between the
    built-in `WebSocket` type and the `ws` library. Renaming the import
    solves this too.
    jackfranklin committed Mar 31, 2020
    Copy the full SHA
    b44abf8 View commit details
    Browse the repository at this point in the history