Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade to TypeScript 3.7 #5562

Merged
merged 2 commits into from Mar 31, 2020
Merged

chore: Upgrade to TypeScript 3.7 #5562

merged 2 commits into from Mar 31, 2020

Commits on Mar 31, 2020

  1. chore: Upgrade to TypeScript 3.7 

    TypeScript seems to struggle to understand `Promise.all` when the items
in the array return different types. If we were authoring in TS we could
fix this with TS generics (`Promise.all<OurTypeHere>(...)`) but for now
we can typecast the result. We'll fix this properly when we author in
TS.
    @jackfranklin
    jackfranklin committed Mar 31, 2020
    Copy the full SHA
    d05c8da View commit details
    Browse the repository at this point in the history

  2. Only include generic types if we have inner types

    @jackfranklin
    jackfranklin committed Mar 31, 2020
    Copy the full SHA
    a33e743 View commit details
    Browse the repository at this point in the history