Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade TypeScript to 3.8 #5566

Merged
merged 2 commits into from Apr 1, 2020
Merged

chore: Upgrade TypeScript to 3.8 #5566

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
716bab1
chore: Upgrade TypeScript to 3.8
jackfranklin Apr 1, 2020
9f58bfa
Don't hardcode TS version in test-types
jackfranklin Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@
"tsc": "tsc --version && tsc -p .",
"apply-next-version": "node utils/apply_next_version.js",
"bundle": "npx browserify -r ./index.js:puppeteer -o utils/browser/puppeteer-web.js",
"test-types": "node utils/doclint/generate_types && npx -p typescript@3.2 tsc -p utils/doclint/generate_types/test/",
"test-types": "node utils/doclint/generate_types && npx -p typescript@3.8 tsc -p utils/doclint/generate_types/test/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Shall we just drop the @3.8 here, so that it uses the version down below in package.json?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

"unit-bundle": "node utils/browser/test.js"
},
"author": "The Chromium Authors",
Expand Down Expand Up @@ -61,7 +61,7 @@
"pixelmatch": "^4.0.2",
"pngjs": "^3.3.3",
"text-diff": "^1.0.1",
"typescript": "3.7.5"
"typescript": "3.8.3"
},
"browser": {
"./lib/BrowserFetcher.js": false,
Expand Down