Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Skip failing cookie tests in Firefox #5575

Merged
merged 1 commit into from Apr 6, 2020
Merged

chore: Skip failing cookie tests in Firefox #5575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/cookies.spec.js
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@ module.exports.addTests = function({testRunner, expect}) {
await page.goto(server.EMPTY_PAGE);
expect(await page.cookies()).toEqual([]);
});
it('should get a cookie', async({page, server}) => {
it_fails_ffox('should get a cookie', async({page, server}) => {
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => {
document.cookie = 'username=John Doe';
Expand Down Expand Up @@ -71,7 +71,7 @@ module.exports.addTests = function({testRunner, expect}) {
expect(cookies.length).toBe(1);
expect(cookies[0].sameSite).toBe('Lax');
});
it('should get multiple cookies', async({page, server}) => {
it_fails_ffox('should get multiple cookies', async({page, server}) => {
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => {
document.cookie = 'username=John Doe';
Expand Down
2 changes: 1 addition & 1 deletion test/defaultbrowsercontext.spec.js
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p
delete state.browser;
delete state.page;
});
it('page.cookies() should work', async({page, server}) => {
it_fails_ffox('page.cookies() should work', async({page, server}) => {
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => {
document.cookie = 'username=John Doe';
Expand Down