Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Page.emulateMedia doclint failure #5584

Merged
merged 2 commits into from Apr 6, 2020

Commits on Apr 3, 2020

  1. chore: Fix Page.emulateMedia doclint failure

    This is expected as we now alias `emulateMedia` in `index.js` which
    isn't a file checked by DocLint. We alias there to avoid having the
    function overriden by the `asyncInstallHooks` code.
    
    This commit updates doclint to know about methods that we expect it will
    find are missing and in that case just skip over them. We should only do
    this for methods where we plan to deprecate them or we have to define
    them in an odd way to work around some problem (and if that's the case
    long term we should fix that problem so we can define them as normal).
    jackfranklin committed Apr 3, 2020
    Copy the full SHA
    66d01fa View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Update utils/doclint/check_public_api/index.js

    Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
    jackfranklin and mathiasbynens committed Apr 6, 2020
    Copy the full SHA
    a967ffe View commit details
    Browse the repository at this point in the history