Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate src/Dialog to TypeScript #5639

Merged
merged 1 commit into from Apr 16, 2020
Merged

Migrate src/Dialog to TypeScript #5639

merged 1 commit into from Apr 16, 2020

Commits on Apr 16, 2020

  1. chore(typescript): migrate src/Dialog

    This PR changes `src/Dialog.js` to `src/Dialog.ts` and rewrites
    accordingly. Most of the changes are straight forward; the only
    interesting one from a TS point of view is the `DialogType` enum. I
    expose it again as `Dialog.Type` to avoid a breaking change.
    
    This PR also exposed some bugs with our ESLint TypeScript settings and
    applying the overrides, so I fixed those too.
    
    I also updated our DocLint tool to work on TS source files over JS lib
    files if they exist. This is the minimal change to keep the existing doc
    system working as we're working on moving away from this system longer
    term.
    jackfranklin committed Apr 16, 2020
    Copy the full SHA
    7a148ef View commit details
    Browse the repository at this point in the history