Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate src/pipetransport to typescript #5692

Merged
merged 2 commits into from Apr 20, 2020

Commits on Apr 20, 2020

  1. chore: migrate src/pipetransport to typescript

    Hit one bump in the fact that I want to share an interface across files.
    TypeScript only lets you import/export these if you're using ESM, not
    CommonJS. So the two options are:
    
    - Migrate to ESM on a per file basis as we do this migration. This won't
    affect the output as we output as CommonJS.
    - Create a global `types.d.ts` file that we'll use and then migrate to
    ESM after.
    
    Right now I've gone for the second option in order to not introduce more
    changes in one go. But if we end up finding we have lots of
    interfaces/types/etc that we want modules to expose, we might decide
    slowly introducing ESM might be a better way forwards.
    jackfranklin committed Apr 20, 2020
    Copy the full SHA
    820f7ca View commit details
    Browse the repository at this point in the history
  2. Update src/types.d.ts

    Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
    jackfranklin and mathiasbynens committed Apr 20, 2020
    Copy the full SHA
    1f6a7b9 View commit details
    Browse the repository at this point in the history