Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate src/Input to typescript #5710

Merged
merged 3 commits into from Apr 22, 2020
Merged

chore: migrate src/Input to typescript #5710

merged 3 commits into from Apr 22, 2020

Commits on Apr 22, 2020

  1. chore: migrate src/Input to typescript 

    This moves `Keyboard`, `Mouse` and `Touchscreen` to TypeScript. We gain
some nice TS benefits here; by creating a type for all the keycodes we
support we can type the input args as that rather than `string` which
will hopefully save some users some debugging once we ship our TS types
in a future version.
    @jackfranklin
    jackfranklin committed Apr 22, 2020
    Copy the full SHA
    acb0167 View commit details
    Browse the repository at this point in the history

  2. Remove from externs file

    @jackfranklin
    jackfranklin committed Apr 22, 2020
    Copy the full SHA
    ae6cea6 View commit details
    Browse the repository at this point in the history

  3. Update utils/doclint/check_public_api/index.js 

    Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
    @jackfranklin @mathiasbynens
    jackfranklin and mathiasbynens committed Apr 22, 2020
    Copy the full SHA
    df9a728 View commit details
    Browse the repository at this point in the history