Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove src/externs.d.ts #5811

Merged
merged 4 commits into from May 6, 2020
Merged

chore: remove src/externs.d.ts #5811

merged 4 commits into from May 6, 2020

Commits on May 5, 2020

  1. chore: remove src/externs.d.ts 

    It defined global types that we don't want to use, and instead we move
to using interfaces that we import and reference just like with any
other interface.

This means other than Protocol (which I think is fine to leave as is),
there are no other magic global types and you have to import any types
or interfaces that you want.
    @jackfranklin
    jackfranklin committed May 5, 2020
    Copy the full SHA
    1038c12 View commit details
    Browse the repository at this point in the history

  2. fix doclint

    @jackfranklin
    jackfranklin committed May 5, 2020
    Copy the full SHA
    3734f7c View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Clearer naming

    @jackfranklin
    jackfranklin committed May 6, 2020
    Copy the full SHA
    25e5dac View commit details
    Browse the repository at this point in the history

  2. fix doclint failures

    @jackfranklin
    jackfranklin committed May 6, 2020
    Copy the full SHA
    d889323 View commit details
    Browse the repository at this point in the history