Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: private-ise src/Accessibility.ts #5832

Merged
merged 1 commit into from May 7, 2020
Merged

Commits on May 7, 2020

  1. chore: private-ise src/Accessibility.ts

    Now the first pass of migrating to TypeScript is complete I'm going
    through the src files one by one to tidy up the public/private
    interfaces.
    
    Puppeteer used an underscore convention to denote privacy but violates
    this in some places; we should be strict with TypeScript's `public` and
    `private` keywords instead.
    
    This means we'll get nice TS errors if you try to refer to a private
    method/variable, and means when we swap to generating our TS docs the
    tooling knows what method(s) are public and therefore need to be
    documented vs private internals that don't.
    jackfranklin committed May 7, 2020
    Copy the full SHA
    bac5cec View commit details
    Browse the repository at this point in the history