Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when given unsupported product name. #5845

Merged
merged 2 commits into from May 12, 2020
Merged

Warn when given unsupported product name. #5845

merged 2 commits into from May 12, 2020

Commits on May 11, 2020

  1. Warn when given unsupported product name. 

    Fixes #5844.

This change means when a user launches Puppeteer with a product name
that is not supported (which at the time of this commit means it's not
`firefox` or `chrome) we will warn them about it.

Decided on just a warning vs an error because the current behaviour is
that we fallback to launching Chrome and I don't think this warrants a
breaking change.
    @jackfranklin
    jackfranklin committed May 11, 2020
    Copy the full SHA
    7da77af View commit details
    Browse the repository at this point in the history

  2. this cleanup is not needed

    @jackfranklin
    jackfranklin committed May 11, 2020
    Copy the full SHA
    fcad9be View commit details
    Browse the repository at this point in the history