Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extract BrowserRunner into its own module #5850

Merged
merged 2 commits into from May 12, 2020
Merged

chore: extract BrowserRunner into its own module #5850

merged 2 commits into from May 12, 2020

Commits on May 12, 2020

  1. chore: extract BrowserRunner into its own module 

    `src/Launcher.ts` is large and hard to work in. It has multiple objects
defined in it:

* ChromeLauncher
* FirefoxLauncher
* BrowserRunner
* Launcher

This change moves BrowserRunner into its own module. More refactorings
like this will follow but this is the first step.
    @jackfranklin
    jackfranklin committed May 12, 2020
    Copy the full SHA
    65045eb View commit details
    Browse the repository at this point in the history

  2. deal with multiple folders

    @jackfranklin
    jackfranklin committed May 12, 2020
    Copy the full SHA
    fd83bfe View commit details
    Browse the repository at this point in the history