feat(api): add page.emulateVisionDeficiency(type) #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
commented
May 20, 2020
mathiasbynens
force-pushed
the
cvd
branch
4 times, most recently
from
5f90313
to
b0c8e75
Compare
mathiasbynens
changed the title
| const screenshot = await page.screenshot(); | ||
| expect(screenshot).toBeGolden('screenshot-sanity.png'); | ||
| } | ||
| }); |
There was a problem hiding this comment.
nit: I'd personally have one individual it for each test rather than the blocks (I think it leads to nicer errors if a test fails) but take it or leave it
There was a problem hiding this comment.
I see what you're saying. I think the reason it's done this way for existing tests is because we'd otherwise have to duplicate the page.setViewport + page.goto setup for each subtest.
jackfranklin
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it possible for contributors to check this out locally, I've temporarily checked in a random Chromium roll for a binary that works on macOS. Before merging, we'd separate this out to a separate commit which rolls Chromium + updatesThis has now happened as part of #5879.src/protocol.d.ts.