Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate tests to TypeScript. #6075

Merged
merged 3 commits into from Jun 23, 2020
Merged

chore: migrate tests to TypeScript. #6075

merged 3 commits into from Jun 23, 2020

Commits on Jun 22, 2020

  1. chore: migrate tests to TypeScript.

    This CL migrates all the tests to TypeScript. The main benefits of this
    is that we start consuming our TypeScript definitions and therefore find
    errors in them. The act of migrating found some bugs in our definitions
    and now we can be sure to avoid them going forwards.
    
    You'll notice the addition of some `TODO`s in the code; I didn't want
    this CL to get any bigger than it already is but I intend to follow
    those up once this lands. It's mostly figuring out how to extend the
    `expect` types with our `toBeGolden` helpers and some other slight
    confusions with types that the tests exposed.
    jackfranklin committed Jun 22, 2020
    Copy the full SHA
    76f9059 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Update tsconfig.json

    mathiasbynens committed Jun 23, 2020
    Copy the full SHA
    4b8c307 View commit details
    Browse the repository at this point in the history
  2. window -> globalThis

    mathiasbynens committed Jun 23, 2020
    Copy the full SHA
    b33261d View commit details
    Browse the repository at this point in the history