Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tidy up TODO from TS tests migration #6090

Merged
merged 1 commit into from Jun 24, 2020
Merged

chore: tidy up TODO from TS tests migration #6090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 0 additions & 12 deletions test/jshandle.spec.ts
View file
Open in desktop
Expand Up @@ -195,18 +195,6 @@ describe('JSHandle', function () {
await page.evaluate((e) => e.nodeType === Node.TEXT_NODE, element)
);
});
it('should work with nullified Node', async () => {
const { page } = getTestState();

await page.setContent('<section>test</section>');
// TODO (@jackfranklin): this line doesn't do anything. What was intended here?
// await page.evaluate(() => delete Node);
const handle = await page.evaluateHandle(() =>
document.querySelector('section')
);
const element = handle.asElement();
expect(element).not.toBe(null);
});
});

describe('JSHandle.toString', function () {
Expand Down