Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): improve typing of .evaluate() #6096

Merged
merged 5 commits into from Jun 25, 2020
Merged

Commits on Jun 25, 2020

  1. feat(types): improve typing of .evaluate()

    This is the start of the work to take the types from the
    `@types/puppeteer` repository and port them into our repo so we can ship
    our built-in types out the box.
    
    This change types the `evaluate` function properly. It takes a generic
    type which is the type of the function you're passing, and the arguments
    and the return that you get back from the `evaluate` call are typed
    correctly.
    jackfranklin authored and mathiasbynens committed Jun 25, 2020
    Copy the full SHA
    3f9f8b8 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e9f2794 View commit details
    Browse the repository at this point in the history
  3. fix missing importn

    jackfranklin committed Jun 25, 2020
    Copy the full SHA
    efcd989 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    07c4c5c View commit details
    Browse the repository at this point in the history
  5. docs

    jackfranklin committed Jun 25, 2020
    Copy the full SHA
    57f8234 View commit details
    Browse the repository at this point in the history