Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Windows skipped tests. #6133

Merged
merged 1 commit into from Jul 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 3 additions & 8 deletions test/headful.spec.ts
Expand Up @@ -22,7 +22,7 @@ import expect from 'expect';
import {
getTestState,
describeChromeOnly,
itFailsWindowsUntilDate,
itFailsWindows,
} from './mocha-utils';
import rimraf from 'rimraf';

Expand Down Expand Up @@ -91,15 +91,10 @@ describeChromeOnly('headful tests', function () {
expect(pages).toEqual(['about:blank']);
await browser.close();
});
itFailsWindowsUntilDate(
/* We have deferred fixing this test on Windows in favour of
* getting all other Windows tests running on CI. Putting this
* date in to force us to come back and debug properly in the
* future.
*/
new Date('2020-07-01'),
itFailsWindows(
'headless should be able to read cookies written by headful',
async () => {
/* Needs investigation into why but this fails consistently on Windows CI. */
const { server, puppeteer } = getTestState();

const userDataDir = await mkdtempAsync(TMP_FOLDER);
Expand Down
2 changes: 1 addition & 1 deletion test/launcher.spec.ts
Expand Up @@ -472,7 +472,7 @@ describe('Launcher specs', function () {
* properly with help from the Mozilla folks.
*/
itFailsWindowsUntilDate(
new Date('2020-07-01'),
new Date('2020-07-30'),
'should be able to launch Firefox',
async () => {
const { puppeteer } = getTestState();
Expand Down
7 changes: 7 additions & 0 deletions test/mocha-utils.ts
Expand Up @@ -170,6 +170,13 @@ export const itFailsWindowsUntilDate = (
return it(description, body);
};

export const itFailsWindows = (description: string, body: Mocha.Func) => {
if (os.platform() === 'win32') {
return xit(description, body);
}
return it(description, body);
};

export const describeFailsFirefox = (
description: string,
body: (this: Mocha.Suite) => void
Expand Down