Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): add types for $eval #6135

Merged
merged 1 commit into from Jul 2, 2020
Merged

feat(types): add types for $eval #6135

merged 1 commit into from Jul 2, 2020

Commits on Jul 2, 2020

  1. feat(types): add types for $eval 

    This pulls in the types (based on the DefinitelyTyped repo) for
`page.$eval` (and the `$eval` method on other classes). The `$eval`
method is quite hard to type due to the way we wrap and unwrap
ElementHandles that are passed to / returned from the `pageFunction`
that users provide.

Longer term we can improve the types by providing type overloads as
DefinitelyTyped does but I've deferred that for now (see the `TODO` in
the code for more details).
    @jackfranklin
    jackfranklin committed Jul 2, 2020
    Copy the full SHA
    ee3f446 View commit details
    Browse the repository at this point in the history