Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix isNode variable not properly detecting Node.js environment #6148

Merged
merged 1 commit into from Jul 3, 2020
Merged

fix: fix isNode variable not properly detecting Node.js environment #6148

merged 1 commit into from Jul 3, 2020

Commits on Jul 3, 2020

  1. fix: fix isNode variable not properly detecting Node.js environment 

    This patch fixes Node.js being detected by the lack of `global.document` which isn't necessairly always true in Node (example: using JSDOM library). Instead, we're now detecting `process.versions.node` being present, which I copied over from [here](https://github.com/MatthewSH/is-node/commit/426943ae936536f9c2fd10fd58a9a46b59470097#diff-168726dbe96b3ce427e7fedce31bb0bc).

Fixes #6147
    @wojtekmaj
    wojtekmaj committed Jul 3, 2020
    Copy the full SHA
    b59d6e9 View commit details
    Browse the repository at this point in the history