Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use devtools-protocol package #6172

Merged
merged 10 commits into from Jul 10, 2020
Merged

chore: use devtools-protocol package #6172

merged 10 commits into from Jul 10, 2020

Commits on Jul 10, 2020

  1. chore: Use devtools-protocol package 

    Rather than maintain our own protocol we can instead use the devtools-protocol package and pin it to the version of Chromium that Puppeteer is shipping with.

The only changes are naming changes between the bespoke protocol that Puppeteer created and the devtools-protocol one.
    @jackfranklin
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    7d5288a View commit details
    Browse the repository at this point in the history

  2. Ensure the right devtools-protocol package version

    @jackfranklin
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    f94e7c2 View commit details
    Browse the repository at this point in the history

  3. fix typo in travis

    @jackfranklin
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    ff6e12e View commit details
    Browse the repository at this point in the history

  4. Better definition for cdp params

    @jackfranklin
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    4f152a1 View commit details
    Browse the repository at this point in the history

  5. Update scripts/ensure-correct-devtools-protocol-package.ts 

    Co-authored-by: Mathias Bynens <mathias@qiwi.be>
    @jackfranklin @mathiasbynens
    jackfranklin and mathiasbynens committed Jul 10, 2020
    Copy the full SHA
    5977d2f View commit details
    Browse the repository at this point in the history

  6. Update scripts/ensure-correct-devtools-protocol-package.ts 

    Co-authored-by: Mathias Bynens <mathias@qiwi.be>
    @jackfranklin @mathiasbynens
    jackfranklin and mathiasbynens committed Jul 10, 2020
    Copy the full SHA
    0546426 View commit details
    Browse the repository at this point in the history

  7. fix params handling

    @jackfranklin
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    bd23b65 View commit details
    Browse the repository at this point in the history

  8. invalid syntax fix

    @jackfranklin
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    925b3b1 View commit details
    Browse the repository at this point in the history

  9. generate docs

    @jackfranklin
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    8438dd4 View commit details
    Browse the repository at this point in the history

  10. doclint fixes

    @jackfranklin
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    cfd19e6 View commit details
    Browse the repository at this point in the history