Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): migrate Connection + CDP event defs #6180

Merged
merged 1 commit into from Jul 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 0 additions & 11 deletions new-docs/puppeteer.connection._callbacks.md

This file was deleted.

11 changes: 0 additions & 11 deletions new-docs/puppeteer.connection._closed.md

This file was deleted.

22 changes: 0 additions & 22 deletions new-docs/puppeteer.connection._constructor_.md

This file was deleted.

11 changes: 0 additions & 11 deletions new-docs/puppeteer.connection._delay.md

This file was deleted.

11 changes: 0 additions & 11 deletions new-docs/puppeteer.connection._lastid.md

This file was deleted.

15 changes: 0 additions & 15 deletions new-docs/puppeteer.connection._onclose.md

This file was deleted.

22 changes: 0 additions & 22 deletions new-docs/puppeteer.connection._onmessage.md

This file was deleted.

22 changes: 0 additions & 22 deletions new-docs/puppeteer.connection._rawsend.md

This file was deleted.

11 changes: 0 additions & 11 deletions new-docs/puppeteer.connection._sessions.md

This file was deleted.

11 changes: 0 additions & 11 deletions new-docs/puppeteer.connection._transport.md

This file was deleted.

11 changes: 0 additions & 11 deletions new-docs/puppeteer.connection._url.md

This file was deleted.

24 changes: 0 additions & 24 deletions new-docs/puppeteer.connection.createsession.md

This file was deleted.

15 changes: 0 additions & 15 deletions new-docs/puppeteer.connection.dispose.md

This file was deleted.

22 changes: 0 additions & 22 deletions new-docs/puppeteer.connection.fromsession.md

This file was deleted.

45 changes: 0 additions & 45 deletions new-docs/puppeteer.connection.md

This file was deleted.

23 changes: 0 additions & 23 deletions new-docs/puppeteer.connection.send.md

This file was deleted.

24 changes: 0 additions & 24 deletions new-docs/puppeteer.connection.session.md

This file was deleted.

15 changes: 0 additions & 15 deletions new-docs/puppeteer.connection.url.md

This file was deleted.

1 change: 0 additions & 1 deletion new-docs/puppeteer.md
Expand Up @@ -13,7 +13,6 @@
| [BrowserContext](./puppeteer.browsercontext.md) | BrowserContexts provide a way to operate multiple independent browser sessions. When a browser is launched, it has a single BrowserContext used by default. The method [Browser.newPage](./puppeteer.browser.newpage.md) creates a page in the default browser context. |
| [BrowserFetcher](./puppeteer.browserfetcher.md) | BrowserFetcher can download and manage different versions of Chromium and Firefox. |
| [CDPSession](./puppeteer.cdpsession.md) | The <code>CDPSession</code> instances are used to talk raw Chrome Devtools Protocol. |
| [Connection](./puppeteer.connection.md) | |
| [ConsoleMessage](./puppeteer.consolemessage.md) | ConsoleMessage objects are dispatched by page via the 'console' event. |
| [Coverage](./puppeteer.coverage.md) | The Coverage class provides methods to gathers information about parts of JavaScript and CSS that were used by the page. |
| [Dialog](./puppeteer.dialog.md) | Dialog instances are dispatched by the [Page](./puppeteer.page.md) via the <code>dialog</code> event. |
Expand Down
5 changes: 2 additions & 3 deletions src/common/Browser.ts
Expand Up @@ -18,9 +18,8 @@ import { assert } from './assert';
import { helper } from './helper';
import { Target } from './Target';
import { EventEmitter } from './EventEmitter';
import { Events } from './Events';
import Protocol from '../protocol';
import { Connection } from './Connection';
import { Connection, ConnectionEmittedEvents } from './Connection';
import { Page } from './Page';
import { ChildProcess } from 'child_process';
import { Viewport } from './PuppeteerViewport';
Expand Down Expand Up @@ -194,7 +193,7 @@ export class Browser extends EventEmitter {
);

this._targets = new Map();
this._connection.on(Events.Connection.Disconnected, () =>
this._connection.on(ConnectionEmittedEvents.Disconnected, () =>
this.emit(BrowserEmittedEvents.Disconnected)
);
this._connection.on('Target.targetCreated', this._targetCreated.bind(this));
Expand Down