Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: forbid importing src/common/Events.ts #6183

Merged
merged 1 commit into from Jul 8, 2020
Merged

chore: forbid importing src/common/Events.ts #6183

merged 1 commit into from Jul 8, 2020

Commits on Jul 8, 2020

  1. chore: forbid importing src/common/Events.ts 

    This file is now deprecated and only used by the coverage tool and
DocLint - these tools will be updated to not rely on it in the future.

We now have events defined per class - e.g. all the events that `Page`
can emit are defined in the `PageEmittedEvents` enum, and similar. We
have to keep `Events.ts` around for the aforementioned tools, but don't
want its usage creeping back into our source code.
    @jackfranklin
    jackfranklin committed Jul 8, 2020
    Copy the full SHA
    c7b05cf View commit details
    Browse the repository at this point in the history