Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove src/api.ts #6191

Merged
merged 1 commit into from Jul 10, 2020
Merged

chore: remove src/api.ts #6191

merged 1 commit into from Jul 10, 2020

Commits on Jul 10, 2020

  1. chore: remove src/api.ts

    Now the async hooks helper is gone api.ts was only used by the coverage
    tools and by doclint.
    
    DocLint is nearing the end of its lifespan with the TSDoc work, so I
    focused on how best to define a list of modules for the coverage
    tooling. They define an object of classes, and the path to that module.
    They need the full path because we also check if the module exports any
    events that need to be emitted - the coverage tool asserts that the
    emitting of those events is also tested.
    
    It's not _great_ that DocLint relies on a constant defined in the
    coverage utils, but it should only be this way for a short period of
    time and no one is actively working on DocLint (bar the effort to remove
    it) so I don't think this is worth worrying about.
    
    This change also broke the DocLint tests; based on the fact that DocLint is on its way out it doesn't feel worth fixing the tests, so this commit also removes them.
    jackfranklin committed Jul 10, 2020
    Copy the full SHA
    272e0c2 View commit details
    Browse the repository at this point in the history