Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chromium): roll Chromium to r768783 #6201

Merged
merged 4 commits into from Jul 10, 2020
Merged

feat(chromium): roll Chromium to r768783 #6201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7c92ca
feat(chromium): roll Chromium to r768783
hanselfmu-chromium Jul 10, 2020
5d9c4f5
fix: update unit test for crrev:2135046
hanselfmu-chromium Jul 10, 2020
8e777dc
fix: remove .only in unit test
hanselfmu-chromium Jul 10, 2020
cd09364
chore: update devtools-protocol revision
hanselfmu-chromium Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@
"license": "Apache-2.0",
"dependencies": {
"debug": "^4.1.0",
"devtools-protocol": "0.0.754670",
"devtools-protocol": "0.0.767361",
"extract-zip": "^2.0.0",
"https-proxy-agent": "^4.0.0",
"mime": "^2.0.3",
Expand Down
2 changes: 1 addition & 1 deletion src/revisions.ts
View file
Open in desktop
Expand Up @@ -20,6 +20,6 @@ type Revisions = Readonly<{
}>;

export const PUPPETEER_REVISIONS: Revisions = {
chromium: '756035',
chromium: '768783',
firefox: 'latest',
};
4 changes: 3 additions & 1 deletion test/cookies.spec.ts
View file
Open in desktop
Expand Up @@ -406,7 +406,9 @@ describe('Cookie specs', () => {
expect(await page.evaluate('document.cookie')).toBe(
'localhost-cookie=best'
);
expect(await page.frames()[1].evaluate('document.cookie')).toBe('');
expect(await page.frames()[1].evaluate('document.cookie')).toBe(
'127-cookie=worst'
);

expect(await page.cookies()).toEqual([
{
Expand Down
3 changes: 2 additions & 1 deletion utils/check_availability.js
View file
Open in desktop
Expand Up @@ -17,7 +17,8 @@

const assert = require('assert');
const https = require('https');
const BrowserFetcher = require('../lib/BrowserFetcher').BrowserFetcher;
// run `npm run dev-install` if lib dir is missing
const BrowserFetcher = require('../lib/cjs/node/BrowserFetcher').BrowserFetcher;

const SUPPORTER_PLATFORMS = ['linux', 'mac', 'win32', 'win64'];
const fetchers = SUPPORTER_PLATFORMS.map(
Expand Down