Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better describe how to install Firefox Nightly with Puppeteer #6226

Merged
merged 3 commits into from Jul 16, 2020
Merged

Better describe how to install Firefox Nightly with Puppeteer #6226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
417ac95
docs: add env variable to the error message
christian-bromann Jul 16, 2020
dcc5765
docs: enhance puppeteer.product docs
christian-bromann Jul 16, 2020
7cb213a
Update src/node/Launcher.ts
christian-bromann Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api.md
View file
Open in desktop
Expand Up @@ -593,7 +593,7 @@ const browser = await puppeteer.launch({
#### puppeteer.product
- returns: <[string]> returns the name of the browser that is under automation (`"chrome"` or `"firefox"`)

The product is set by the `PUPPETEER_PRODUCT` environment variable or the `product` option in [puppeteer.launch([options])](#puppeteerlaunchoptions) and defaults to `chrome`. Firefox support is experimental.
The product is set by the `PUPPETEER_PRODUCT` environment variable or the `product` option in [puppeteer.launch([options])](#puppeteerlaunchoptions) and defaults to `chrome`. Firefox support is experimental and requires to install Puppeteer via `PUPPETEER_PRODUCT=firefox npm i puppeteer`.


### class: BrowserFetcher
Expand Down
2 changes: 1 addition & 1 deletion src/node/Launcher.ts
View file
Open in desktop
Expand Up @@ -771,7 +771,7 @@ function resolveExecutablePath(
}
const revisionInfo = browserFetcher.revisionInfo(launcher._preferredRevision);
const missingText = !revisionInfo.local
? `Could not find browser revision ${launcher._preferredRevision}. Run "npm install" or "yarn install" to download a browser binary.`
? `Could not find browser revision ${launcher._preferredRevision}. Run "PUPPETEER_PRODUCT=firefox npm install" or "PUPPETEER_PRODUCT=firefox yarn install" to download a supported Firefox browser binary.`
: null;
return { executablePath: revisionInfo.executablePath, missingText };
}
Expand Down