Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium): roll Chromium to r782078 #6250

Merged
merged 5 commits into from Jul 20, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -44,7 +44,7 @@
"license": "Apache-2.0",
"dependencies": {
"debug": "^4.1.0",
"devtools-protocol": "0.0.767361",
"devtools-protocol": "0.0.781568",
"extract-zip": "^2.0.0",
"https-proxy-agent": "^4.0.0",
"mime": "^2.0.3",
Expand Down
2 changes: 1 addition & 1 deletion src/revisions.ts
Expand Up @@ -20,6 +20,6 @@ type Revisions = Readonly<{
}>;

export const PUPPETEER_REVISIONS: Revisions = {
chromium: '768783',
chromium: '782078',
firefox: 'latest',
};
4 changes: 1 addition & 3 deletions test/cookies.spec.ts
Expand Up @@ -406,9 +406,7 @@ describe('Cookie specs', () => {
expect(await page.evaluate('document.cookie')).toBe(
'localhost-cookie=best'
);
expect(await page.frames()[1].evaluate('document.cookie')).toBe(
'127-cookie=worst'
);
expect(await page.frames()[1].evaluate('document.cookie')).toBe('');

expect(await page.cookies()).toEqual([
{
Expand Down
2 changes: 1 addition & 1 deletion test/elementhandle.spec.ts
Expand Up @@ -49,7 +49,7 @@ describe('ElementHandle specs', function () {
const elementHandle = await nestedFrame.$('div');
const box = await elementHandle.boundingBox();
if (isChrome)
expect(box).toEqual({ x: 28, y: 260, width: 264, height: 18 });
expect(box).toEqual({ x: 28, y: 182, width: 264, height: 18 });
else expect(box).toEqual({ x: 28, y: 182, width: 254, height: 18 });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now these two expect calls are the same, I think we can lose the conditional.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The width is different though?

});
it('should return null for invisible elements', async () => {
Expand Down
5 changes: 3 additions & 2 deletions utils/check_availability.js
Expand Up @@ -18,7 +18,8 @@
const assert = require('assert');
const https = require('https');
// run `npm run dev-install` if lib dir is missing
const BrowserFetcher = require('../lib/cjs/node/BrowserFetcher').BrowserFetcher;
const BrowserFetcher = require('../lib/cjs/puppeteer/node/BrowserFetcher.js')
.BrowserFetcher;

const SUPPORTER_PLATFORMS = ['linux', 'mac', 'win32', 'win64'];
const fetchers = SUPPORTER_PLATFORMS.map(
Expand Down Expand Up @@ -163,7 +164,7 @@ async function checkRollCandidate() {
10
);
const currentRevision = parseInt(
require('../lib/cjs/revisions').PUPPETEER_REVISIONS.chromium,
require('../lib/cjs/puppeteer/revisions').PUPPETEER_REVISIONS.chromium,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry I missed these when I did the restructure; thank you for fixing 👍

10
);

Expand Down