feat: page.waitForTimeout #6268
Merged
+296
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Jul 23, 2020
OrKoN
reviewed
Jul 23, 2020
| * tests. Until we remove this method we still want to ensure we don't break | ||
| * it. | ||
| */ | ||
| beforeEach(() => sinon.stub(console, 'warn').callsFake(() => {})); |
There was a problem hiding this comment.
Automatically after each test: https://github.com/puppeteer/puppeteer/blob/main/test/mocha-utils.ts#L273
OrKoN
approved these changes
Jul 23, 2020
jackfranklin
force-pushed
the
wait-for-timeout
branch
from
b015a86
to
aa34081
Compare
hanselfmu
approved these changes
Jul 27, 2020
mathiasbynens
approved these changes
Jul 28, 2020
devtools-bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Jul 29, 2020
The next version of Puppeteer will deprecate `page.waitFor` (see puppeteer/puppeteer#6268 for details) so this CL gets us ahead of the curve by removing all the usages of it. Change-Id: I0d8cf154b6ee561036df1cd999a64fac1b01cc6c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2325220 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
babot
pushed a commit
to binaryage/dirac
that referenced
this pull request
Jul 30, 2020
The next version of Puppeteer will deprecate `page.waitFor` (see puppeteer/puppeteer#6268 for details) so this CL gets us ahead of the curve by removing all the usages of it. Change-Id: I0d8cf154b6ee561036df1cd999a64fac1b01cc6c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2325220 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
campersau
added a commit
to campersau/ungit
that referenced
this pull request
Sep 12, 2020
campersau
added a commit
to campersau/ungit
that referenced
this pull request
Sep 12, 2020
campersau
added a commit
to FredrikNoren/ungit
that referenced
this pull request
Sep 12, 2020
* use waitForTimeout puppeteer/puppeteer#6268 * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
page.waitForTimeout(and subsequently,frame.waitForTimeout) and deprecates thepage.waitForandframe.waitFormethods.None of the functionality that
waitForprovided is lost; it's now all available via the more explicitwaitForXfunctions. This PR doesn't removewaitFor, all its functionality is still available. I'd suggest we ship this as a minor release, give it a while for users to adjust and then removewaitForin the next reasonable breaking release.Fixes #6214.