Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken socks proxy for binary downloads #6274

Closed
wants to merge 2 commits into from
Closed

fix: broken socks proxy for binary downloads #6274

wants to merge 2 commits into from

Commits on Jul 24, 2020

  1. fix(BrowserFetcher): allow socks proxy to be used 

    Using `ALL_PROXY=socks...` and `proxy=socks...` in `npmrc` causes installer to fail silently. This patch allows usage of socks proxies.

Fixes: puppeteer#4401
    @spacelatte
    spacelatte committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    5c40a62 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Merge branch 'main' into browser-fetcher-socks-proxy-pr

    @pvtmert
    pvtmert committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    51b63d1 View commit details
    Browse the repository at this point in the history