Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add channel parameter in check_availability roll mode #6400

Closed
wants to merge 1 commit into from

Conversation

hanselfmu
Copy link
Collaborator

This PR adds an optional parameter in check_availability.js -r mode (roll mode) to specify the channel (stable | dev | beta) to check the latest revision from.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@@ -97,7 +104,7 @@ function main() {
case 'f':
break;
case 'r':
checkRollCandidate();
checkRollCandidate(args[1]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's assert that args[1] is one of the supported values here, and error out otherwise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const supportedChannels = new Map(['stable', 'beta', 'dev']);

@hanselfmu
Copy link
Collaborator Author

Closing this in favor of #6399 .

@hanselfmu hanselfmu closed this Sep 8, 2020
@hanselfmu hanselfmu deleted the check-availability-add-channel branch September 8, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants