Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(frame): fix url fragment test #6416

Merged
merged 1 commit into from Sep 14, 2020
Merged

test(frame): fix url fragment test #6416

merged 1 commit into from Sep 14, 2020

Conversation

campersau
Copy link
Contributor

by using an actual fragment

references #6398 (comment)

@campersau
test(frame): fix url fragment test
8c05ba3 
by using an actual fragment

references puppeteer#6398
mathiasbynens
mathiasbynens approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mathiasbynens mathiasbynens merged commit 083ea41 into puppeteer:main Sep 14, 2020
@campersau campersau deleted the fragmenttest branch September 14, 2020 11:57
@YusukeIwaki YusukeIwaki mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@campersau @mathiasbynens @googlebot