Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of shared TaskQueue for page.screenshot() #6714

Merged
merged 6 commits into from Sep 23, 2021

Conversation

dmitrysteblyuk
Copy link
Contributor

Issue #6713.
Please, notice that I changed the return type of page.screenshot() back to Promise<Buffer | string>.
I did it because I couldn't find any place where it returns void.
Let me know if it was a mistake on my part, I'll change it back.

@google-cla google-cla bot added the cla: yes label Dec 31, 2020
@dmitrysteblyuk
Copy link
Contributor Author

@jackfranklin sorry for the ping, but Travis appears not to be working for the last 5 days.

@mathiasbynens
Copy link
Member

@jackfranklin sorry for the ping, but Travis appears not to be working for the last 5 days.

Yeah, we're aware of this. Travis essentially removed support for their free plan, so we'll have to migrate to GitHub Actions. #6726

@jackfranklin
Copy link
Collaborator

@dmitrysteblyuk thank you for this PR and for the bug report. This looks good to me. Now we've landed GitHub actions into the codebase, would you mind rebasing your PR? Then we can see if CI is happy 👍

@jackfranklin
Copy link
Collaborator

@mathiasbynens PTAL.

@google-cla
Copy link

google-cla bot commented Sep 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 23, 2021
@jschfflr
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 23, 2021
@jschfflr jschfflr self-assigned this Sep 23, 2021
@jschfflr jschfflr merged commit f2e1927 into puppeteer:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants