New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert removal of shared TaskQueue for page.screenshot()
#6714
Conversation
@jackfranklin sorry for the ping, but Travis appears not to be working for the last 5 days. |
Yeah, we're aware of this. Travis essentially removed support for their free plan, so we'll have to migrate to GitHub Actions. #6726 |
@dmitrysteblyuk thank you for this PR and for the bug report. This looks good to me. Now we've landed GitHub actions into the codebase, would you mind rebasing your PR? Then we can see if CI is happy 👍 |
f1f9f1c
to
98dcb56
Compare
@mathiasbynens PTAL. |
03a4ca1
to
d4b17bd
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Issue #6713.
Please, notice that I changed the return type of
page.screenshot()
back toPromise<Buffer | string>
.I did it because I couldn't find any place where it returns
void
.Let me know if it was a mistake on my part, I'll change it back.