Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agnostification): inject dependecies(ws, fs, path etc) for common in entry(node, web) initialization. #6731

Closed
wants to merge 5 commits into from

Conversation

webee
Copy link

@webee webee commented Jan 6, 2021

related to #6125
by add a Config module which contains the node specific packages(ws, fs etc), let the common depend on it(dependeny injection), we can remove isNode check in common code, as well as dynamic imports.
every entry(node, web) needs initialize the Config before export the Puppeteer object.

@google-cla
Copy link

google-cla bot commented Jan 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 6, 2021
@webee
Copy link
Author

webee commented Jan 6, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 6, 2021
@webee webee changed the title chore(agnostification): add Config for common chore(agnostification): inject dependecies(ws, fs, path etc) for common in entry(node, web) initialization. Jan 6, 2021
chore(agnostification): add Config for common

chore(agnostification): move Config to common dir and add path config

chore(agnostification): fix debug function not set error
@webee webee closed this Jan 7, 2021
@webee webee deleted the remove-dynamic-import branch January 7, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant