Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): fix typo around test directory link #6831

Merged
merged 4 commits into from
Feb 8, 2021
Merged

docs(contributing): fix typo around test directory link #6831

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ecc329
docs(contributing): fix typo around test directory link
theDavidBarton Feb 7, 2021
05e087e
docs(contributing): specify README.md link
theDavidBarton Feb 7, 2021
19fddcf
Update CONTRIBUTING.md
mathiasbynens Feb 8, 2021
437cb0a
Merge branch 'main' into contributing-test-folder-fix
mathiasbynens Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ There are additional considerations for dependencies that are environment agonis
- Tests should not depend on external services.
- Tests should work on all three platforms: Mac, Linux and Win. This is especially important for screenshot tests.

Puppeteer tests are located in the test directory ([`test`](https://github.com/puppeteer/puppeteer/blob/main/test/) and are written using Mocha. See [`test/README.md`](https://github.com/puppeteer/puppeteer/blob/main/test/) for more details.
Puppeteer tests are located in the [`test`](https://github.com/puppeteer/puppeteer/blob/main/test/) directory and are written using Mocha. See [`test/README.md`](https://github.com/puppeteer/puppeteer/blob/main/test/README.md) for more details.
mathiasbynens marked this conversation as resolved.
Show resolved Hide resolved

Despite being named 'unit', these are integration tests, making sure public API methods and events work as expected.

Expand Down