Enable unit tests for Firefox on Windows #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
force-pushed
the
ci_windows
branch
6 times, most recently
from
7829d4e
to
276d4cc
Compare
|
It's still busted so I'll have to take a look at https://bugzilla.mozilla.org/show_bug.cgi?id=1656962 first. We do not experience similar issues for other test jobs in our CI. |
whimboo
force-pushed
the
ci_windows
branch
6 times, most recently
from
0f62a74
to
31147c3
Compare
whimboo
changed the title
whimboo
changed the title
|
This PR is ready to be reviewed now. I hope the way that I used is fine for you. |
whimboo
commented
Mar 4, 2021
mathiasbynens
approved these changes
Mar 4, 2021
|
@jschfflr I updated the patch and all tests are passing. Would you mind merging the PR? |
jschfflr
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eventually fix issue #5673.
First I would like to see if tests might work again. If not further debugging is necessary.