New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove broken executable "resolver" for arm64 arch #7013
Conversation
Same as puppeteer#6914 but with a different commit message. With this change, we don't need to patch puppeteer on M1. See puppeteer#6622.
I don't think the test failure is related to this change. |
@jackfranklin can you take a look at this? |
@theDavidBarton could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theDavidBarton could you take a look?
I have taken a look gladly but I have no write access on the project, so I let @jackfranklin or other members approve it in a second round.
Note: the very same change was already approved by Mathias back in February 2021, see #6914 (review). This time commit-msg is OK.
Thank you @theDavidBarton. I randomly picked you since I didn't know a better way to get the attention of someone who has write access. I apologize if there is a process for getting reviews that I missed. |
No worries 😊 |
03a4ca1
to
d4b17bd
Compare
@domoritz It has been a while since this change has been uploaded. Could you verify that it's still needed? |
I don't think it is with #7099. |
Thanks @domoritz! |
Same as #6914 but with a different commit message.
With this change, we don't need to patch puppeteer on M1. See #6622.