docs(new): export ExceptionThrownCallback and ConsoleAPICalledCalledC… #7053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback in WebWorker
…sewifeHacker/puppeteer into 6118_handle_tsdoc_warnings_webworker
* captureBeyondViewport as screenshot optinal param * lint fixes * fix lint * apply Emulation.setDeviceMetricsOverride in case captureBeyondViewport is false
|
@HousewifeHacker thanks for your PR - it looks like since you opened it someone else has made the changes and now this PR is not changing anything. I'm sorry that I missed this PR for 9 days and therefore this got missed. I really appreciate your contribution and hopefully next time we can land it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…allback in WebWorker
Some progress towards #6118
Quiets the warnings:
Warning: src/common/WebWorker.ts:72:3 - (ae-forgotten-export) The symbol "ConsoleAPICalledCallback" needs to be exported by the entry point api-docs-entry.d.ts
Warning: src/common/WebWorker.ts:72:3 - (ae-forgotten-export) The symbol "ExceptionThrownCallback" needs to be exported by the entry point api-docs-entry.d.ts
WebWorker uses both in the constructor and is itself exported