Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): allow evaluate functions to take a readonly array as an argument #7072

Merged
merged 5 commits into from Sep 11, 2021
Merged

fix(types): allow evaluate functions to take a readonly array as an argument #7072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77b65e1
fix(types): allow evaluate functions to take a readonly array as an a…
n10v Apr 8, 2021
ec5e9a8
Merge branch 'main' into fix-evaluate-readonly
n10v Jun 29, 2021
24b2b07
fix(types): Use only readonly for JSONArray
n10v Jun 29, 2021
f7e4ea8
Merge branch 'main' into fix-evaluate-readonly
jschfflr Sep 11, 2021
10de867
Merge branch 'main' into fix-evaluate-readonly
jschfflr Sep 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/EvalTypes.ts
View file
Open in desktop
Expand Up @@ -54,7 +54,7 @@ export type Serializable =
/**
* @public
*/
export type JSONArray = Serializable[];
export type JSONArray = readonly Serializable[];

/**
* @public
Expand Down
11 changes: 11 additions & 0 deletions test/frame.spec.ts
View file
Open in desktop
Expand Up @@ -79,6 +79,17 @@ describe('Frame specs', function () {
'Execution context is not available in detached frame'
);
});

it('allows readonly array to be an argument', async () => {
const { page, server } = getTestState();
await page.goto(server.EMPTY_PAGE);
const mainFrame = page.mainFrame();

// This test checks if Frame.evaluate allows a readonly array to be an argument.
// See https://github.com/puppeteer/puppeteer/issues/6953.
const readonlyArray: readonly string[] = ['a', 'b', 'c'];
mainFrame.evaluate((arr) => arr, readonlyArray);
});
});

describe('Frame Management', function () {
Expand Down