Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add channel parameter for puppeteer.launch #7389

Merged
merged 6 commits into from Jul 9, 2021
Merged

feat: add channel parameter for puppeteer.launch #7389

merged 6 commits into from Jul 9, 2021
+115 −8

Commits on Jul 8, 2021

  1. feat: add channel parameter 

    Add 'channel' parameter for Puppeteer.launch

Issues: #7340
    @YusukeIwaki
    YusukeIwaki committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d76b2ad View commit details
    Browse the repository at this point in the history

  2. fix: add error handling for Chrome install path detection 

    Add check for detected Chrome install path.
    @YusukeIwaki
    YusukeIwaki committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    9053374 View commit details
    Browse the repository at this point in the history

  3. fix: change priority of channel and executablePath 

    channel should be always respected, even when executablePath is specified.
    @YusukeIwaki
    YusukeIwaki committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    3c4fdfb View commit details
    Browse the repository at this point in the history

  4. fix: add assertion for channel and executablePath

    @YusukeIwaki
    YusukeIwaki committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    9a8a92a View commit details
    Browse the repository at this point in the history

  5. fix: add documentation for channel parameter of puppeteer.launch

    @YusukeIwaki
    YusukeIwaki committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    54b36ac View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Merge branch 'main' into feature/launch_with_channel

    @jschfflr
    jschfflr committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    d3d3918 View commit details
    Browse the repository at this point in the history