New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Apple Silicon chromium builds #7546
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
bce68ad
feat: add support for Apple Silicon chromium builds
7rulnik 1fc9ed2
Merge branch 'main' into chromium-arm64
7rulnik e8bea45
Remove unnecessary change
7rulnik dc6ccd1
Merge branch 'main' into chromium-arm64
7rulnik f7f2274
use arm version only when PUPPETEER_EXPERIMENTAL_CHROMIUM_MAC_ARM is set
7rulnik a87a7ee
Merge remote-tracking branch 'origin/main' into chromium-arm64
7rulnik ffdf1a3
fix prettier
7rulnik 388c994
Merge branch 'main' into chromium-arm64
OrKoN 39512f6
Merge remote-tracking branch 'upstream/main' into chromium-arm64
7rulnik 016b824
fix prettier
7rulnik 5d97ab9
fix platform detection for firefox
7rulnik 0004f4d
remove useless os import
7rulnik b7a09c4
Merge remote-tracking branch 'upstream/main' into chromium-arm64
7rulnik faef7e5
Add info about PUPPETEER_EXPERIMENTAL_CHROMIUM_MAC_ARM to api doc
7rulnik 8e6fa8c
Add info about PUPPETEER_EXPERIMENTAL_CHROMIUM_MAC_ARM to contributin…
7rulnik 28edb19
Merge branch 'main' into chromium-arm64
OrKoN 6ca3d67
Merge branch 'main' into chromium-arm64
OrKoN File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't feel right for me, but firefox ships universal build, so in
downloadURLs
we can't use the separate url for firefox for MacOS ARM because of string interpolationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as workaround we can pass platform as query parameter in firefox case and remove this hack