fix(types): ensure compiler directives are at top #7828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround to make Puppeteers types work without DOM types unfortunately breaks tsc's module resolution, since it put a declaration before a tripple slash compiler directive. This makes the directive invalid and it is therefore ignored by the typescript compiler when resolving modules. This fix instead appends the `global.d.ts` declarations at the end of the generated `types.d.ts` file, ensuring that any directives stays at the top of the file.
OrKoN
approved these changes
Dec 8, 2021
|
FYI @jackfranklin |
|
LGTM! |
jackfranklin
approved these changes
Dec 9, 2021
|
After thinking a bit more about this, I think we should move forward by reverting instead: #7829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround to make Puppeteers types work without DOM types
unfortunately breaks tsc's module resolution, since it put a declaration
before a triple-slash compiler directive. This makes the directive
invalid and it is therefore ignored by the typescript compiler when
resolving modules.
This fix instead appends the
global.d.tsdeclarations at the end ofthe generated
types.d.tsfile, ensuring that any directives stays atthe top of the file.