Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure ElementHandle.waitForSelector is evaluated in the right context #7843

Merged
merged 1 commit into from Dec 21, 2021
Merged

fix: make sure ElementHandle.waitForSelector is evaluated in the right context #7843

merged 1 commit into from Dec 21, 2021

Commits on Dec 15, 2021

  1. fix: make sure ElementHandle.waitForSelector is evaluated in the righ… 

    …t context

So it appears that all bindings are added to the secondary world and all
evaluations are also running there. ElementHandle.evaluate is returning
handles from the main world though. Therefore, we need to be careful
and adopt handles to the right context before doing waitForSelector
So it appears that all bindings are added to the secondary world and all
evaluations are also running there. ElementHandle.evaluate is returning
handles from the main world though. Therefore, we need to be careful
and adopt handles to the right context before doing waitForSelector..
    @OrKoN
    OrKoN committed Dec 15, 2021
    Copy the full SHA
    69c0a85 View commit details
    Browse the repository at this point in the history