Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page): Page.createIsolatedWorld error catching has been added #7848

Merged
merged 11 commits into from Mar 2, 2022
Merged

fix(page): Page.createIsolatedWorld error catching has been added #7848

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3c20ab4
fix(page): Page.createIsolatedWorld error catching has been added
Dec 15, 2021
56d88d3
fix(page): console.error was replaced by debugError
Dec 29, 2021
0eebe4e
fix(page): Page.createIsolatedWorld error catching has been added
Dec 15, 2021
32d4312
fix(page): console.error was replaced by debugError
Dec 29, 2021
014c4f1
Merge branch 'fix/create-isolated-world' of https://github.com/DimaSh…
Feb 25, 2022
35b38fc
fix(page): eslint changes
Feb 25, 2022
e6894cf
Merge branch 'main' into fix/create-isolated-world
OrKoN Feb 28, 2022
167c5e6
Merge branch 'main' into fix/create-isolated-world
OrKoN Mar 1, 2022
84e9beb
Merge branch 'main' into fix/create-isolated-world
OrKoN Mar 2, 2022
69a2b28
Merge branch 'main' into fix/create-isolated-world
OrKoN Mar 2, 2022
7949da7
Merge branch 'main' into fix/create-isolated-world
OrKoN Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/FrameManager.ts
View file
Open in desktop
Expand Up @@ -398,7 +398,7 @@ export class FrameManager extends EventEmitter {
frameId: frame._id,
worldName: name,
grantUniveralAccess: true,
})
}).catch(console.error)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier this was

Suggested change
}).catch(console.error)
}).catch(debugError)

imported with import {debugError} from './helper';. Should it be the debugError instead?

(For some reason it got removed in 4d9dc8c)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good now

)
);
}
Expand Down