Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: page.pdf producing an invalid pdf #7868

Merged
merged 4 commits into from Jan 26, 2022
Merged

fix: page.pdf producing an invalid pdf #7868

merged 4 commits into from Jan 26, 2022

Commits on Dec 22, 2021

  1. fix: page.pdf producing an invalid pdf 

    When defining a chunk size for <CDPSession>.send('IO.read', { handle, size }), the CDPSession will occassionally indicate an that it has reached the end of file without sending a full pdf. This is documented by the associated issue.

This behavior is not reproducable when leaving out the size parameter. Since the size parameter is not required on the CDPSession side and is merely a suggestion on the stream side, we can safely leave it out.

Refs: puppeteer#7757
    @tjacobs3
    tjacobs3 committed Dec 22, 2021
    Copy the full SHA
    ced620c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Merge branch 'main' into main

    @OrKoN
    OrKoN committed Jan 24, 2022
    Copy the full SHA
    90d3c5d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Merge branch 'main' into main

    @OrKoN
    OrKoN committed Jan 26, 2022
    Copy the full SHA
    f0536d5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @OrKoN
    OrKoN committed Jan 26, 2022
    Copy the full SHA
    06022da View commit details
    Browse the repository at this point in the history