Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Apple M1 Chromium builds #7895

Closed
wants to merge 1 commit into from
Closed

Conversation

fengmk2
Copy link

@fengmk2 fengmk2 commented Jan 9, 2022

What kind of change does this PR introduce?

feature

Did you add tests for your changes?
Github Action not support yer actions/runner#805
I run unit test on my local M1 machine.

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information
Firefix is still using the x64 build for Apple M1

@OrKoN
Copy link
Collaborator

OrKoN commented Jan 21, 2022

@mathiasbynens should we add Apple M1 builds before GitHub actions support it?

@mathiasbynens
Copy link
Member

mathiasbynens commented Jan 21, 2022

I worry that this change would make it even harder to find a suitable Chromium revision across all platforms, since this increases the number of different platforms. Speaking of which, would we also need to update https://github.com/puppeteer/puppeteer/blob/main/utils/check_availability.js?

@mathiasbynens should we add Apple M1 builds before GitHub actions support it?

Good point. I don’t think we should ship this until we have a solid testing story. We could land this as an opt-in feature, but then I’d like us to also do the following:

@OrKoN
Copy link
Collaborator

OrKoN commented Feb 11, 2022

Let's close this PR in favour of #7546 which seems to include changes to the check availability script as well.

@OrKoN OrKoN closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants