Commits on Feb 11, 2022

1. fix: always use ENV executable path when present …

   Some recent changes to allow arm64 environments (including M1 macs) to
   launch a chromium installation successfully before arm-compatible builds
   were downloadable prevented the usage of PUPPETEER_EXECUTABLE_PATH in
   some environments. Currently, when the platform is not darwin and the
   arch is arm64, an executable cannot be specified using the environment
   variable.
   
   Generally speaking, environment variables have highest precedence for
   options such as this since they depend on system configuration.
   
   These change:
   
   1. allow the ENV variable to always be used when defined and not
      specified in LaunchOptions (and when not puppeteer-core)
   2. Retain the existing behavior of assuming /usr/bin/chromium-browser on
      platforms like Ubuntu (exact if-conditions preserved to avoid any
      breaking changes)
   3. Add some tests for this particular portion of the code.

   

   jbielick authored and OrKoN committed Feb 11, 2022
   Copy the full SHA

   599dc96 View commit details

   Browse the repository at this point in the history