Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure dom binding is not called after detach #8024

Merged
merged 4 commits into from Feb 17, 2022
Merged

fix: ensure dom binding is not called after detach #8024

merged 4 commits into from Feb 17, 2022

Commits on Feb 17, 2022

  1. fix: ensure dom binding is not called after detatch 

    Fixes puppeteer#7814
    @pmmmwh @OrKoN
    pmmmwh authored and OrKoN committed Feb 17, 2022
    Copy the full SHA
    a2d8ecb View commit details
    Browse the repository at this point in the history

  2. refactor: detach listeners instead

    @OrKoN
    Michael Mok authored and OrKoN committed Feb 17, 2022
    Copy the full SHA
    cdb8b4a View commit details
    Browse the repository at this point in the history

  3. refactor: safer approach

    @OrKoN
    Michael Mok authored and OrKoN committed Feb 17, 2022
    Copy the full SHA
    9ad896b View commit details
    Browse the repository at this point in the history

  4. fix: test in test/page.spec.ts

    @OrKoN
    OrKoN committed Feb 17, 2022
    Copy the full SHA
    ee22219 View commit details
    Browse the repository at this point in the history