Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all tests honour the BINARY envvar. #8092

Merged
merged 1 commit into from Mar 3, 2022
Merged

Ensure all tests honour the BINARY envvar. #8092

merged 1 commit into from Mar 3, 2022

Commits on Mar 3, 2022

  1. fix(tests): Ensure all tests honour BINARY envvar 

    Without this patch, two tests ignore the BINARY envvar, and fail when not using
the embedded chromium, unless the chromium executable path is defined via
PUPPETEER_EXECUTABLE_PATH, which should not be considered according to the
docs.
    @NightTsarina @OrKoN
    NightTsarina authored and OrKoN committed Mar 3, 2022
    Copy the full SHA
    b7847cf View commit details
    Browse the repository at this point in the history